ceres-sees-all/qmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix single key combos activating only once (#25198)

Browse source 
Co-authored-by: Julian Schuler <julianschuler@users.noreply.github.com>
This commit is contained in:
Julian Schuler 2025-11-23 12:25:59 +01:00 • committed by GitHub
parent 4015c40ba4
commit b321789d7b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 23 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/combo/test_combo.cpp
View file

@ -54,3 +54,18 @@ TEST_F(Combo, combo_osmshift_tapped) {
tap_key(key_i);
VERIFY_AND_CLEAR(driver);
}
TEST_F(Combo, combo_single_key_twice) {
TestDriver driver;
KeymapKey key_a(0, 0, 1, KC_A);
set_keymap({key_a});
EXPECT_REPORT(driver, (KC_B));
tap_combo({key_a});
VERIFY_AND_CLEAR(driver);
EXPECT_REPORT(driver, (KC_B));
EXPECT_EMPTY_REPORT(driver);
tap_combo({key_a});
VERIFY_AND_CLEAR(driver);
}

6
tests/combo/test_combos.c
View file

@ -4,14 +4,16 @@
// SPDX-License-Identifier: GPL-2.0-or-later
#include "quantum.h"
enum combos { modtest, osmshift };
enum combos { modtest, osmshift, single_key };
uint16_t const modtest_combo[] = {KC_Y, KC_U, COMBO_END};
uint16_t const osmshift_combo[] = {KC_Z, KC_X, COMBO_END};
uint16_t const single_key_combo[] = {KC_A, COMBO_END};
// clang-format off
combo_t key_combos[] = {
[modtest] = COMBO(modtest_combo, RSFT_T(KC_SPACE)),
[osmshift] = COMBO(osmshift_combo, OSM(MOD_LSFT))
[osmshift] = COMBO(osmshift_combo, OSM(MOD_LSFT)),
[single_key] = COMBO(single_key_combo, KC_B),
};
// clang-format on